Opened 17 years ago

Closed 17 years ago

#7 closed defect (fixed)

History table's proc_cmd column with wildcards

Reported by: Matthew Whiting Owned by: Matthew Whiting
Priority: major Component: pvoconvert: FITS access
Version: Keywords:
Cc:

Description

When wildcards are used on the command line, these get expanded in the string that is written to the proc_cmd entry in the HISTORY table. For directories with a number of files, use of '*' means we rapidly exceed the width of the column.

Perhaps change this so that it just has "pvoconvert <filename>" where <filename> is the tape file from which we start reading the data in the current FITS file? Might be problematic when a FITS file's data run over many tape files. Alternative would be to convert the wildcard into the literal character, so that "pvoconvert *" is written. This is probably better...

Change History (5)

comment:1 Changed 17 years ago by Matthew Whiting

Owner: changed from Matthew Whiting to Matthew Whiting
Status: newassigned

comment:2 Changed 17 years ago by Matthew Whiting

A solution might be to have a "-D" flag so that one can give a full directory. This could then be used instead of a '*'. The problem with the '*' is that the shell expands it out before it passes it through the command line, so pvoconvert can't (as I understand it) tell the difference between the '*' and the full list...

Would have to use glob to get all the filenames out of the directory that was passed, but that shouldn't be too difficult.

comment:3 Changed 17 years ago by Matthew Whiting

Have added the -D option as suggested above, and seems to work fine. The HISTORY table records it as "pvoconvert -D directory/" as you would expect, which I think is clear enough.

Need confirmation that this is OK for a proc_cmd entry, so leaving ticket open.

comment:4 Changed 17 years ago by (none)

milestone: pvoconvert

Milestone pvoconvert deleted

comment:5 Changed 17 years ago by MatthewWhiting

Component: generalpvoconvert: FITS access
Resolution: fixed
Status: assignedclosed

After consulting with Dick, have settled on explicitly writing out the filename that is relevant to the FITS file. This way we ignore all wildcards or the use of the -D flag, and just extract the current input filename.

The full path of the filename is used (as entered on the command line), but only the executable name (and not its path) is used.

Closing the ticket.

MTW.

Note: See TracTickets for help on using tickets.