Opened 16 years ago
Last modified 15 years ago
#142 closed defect
Frequency alignment fails for observations at different frequencies — at Version 4
| Reported by: | Max Voronkov | Owned by: | Max Voronkov |
|---|---|---|---|
| Priority: | normal | Milestone: | ASAP 2.3 |
| Component: | c++ | Version: | 2.0 |
| Severity: | critical | Keywords: | |
| Cc: | Max Voronkov |
Description (last modified by )
Change History (4)
comment:1 Changed 16 years ago by
| Owner: | changed from Malte Marquarding to Malte Marquarding |
|---|---|
| Status: | new → assigned |
comment:2 Changed 16 years ago by
Max,
we are iterating over FREQ_ID which should vary if any of refpix,refval, inc change. So each row in that selection should have the same freqquency set up. Or am I wrong?
comment:3 Changed 16 years ago by
| Owner: | changed from Malte Marquarding to Max Voronkov |
|---|---|
| Status: | assigned → new |
Max,
As discussed this is due to the fact that hits handles only alignment within the same FREQ_ID. What you want is alignment of the same IFNO.
I'll assign it to you but feel free to bounce it back.
comment:4 Changed 16 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
That's OK. I'll probably look at the issue in two weeks time.
Note: See
TracTickets for help on using
tickets.
from Max
It seems to me I found the cause of the problem. In STMath.cc, lines 1828-1830 frequencyAligner<Float>::align method is called with useCachedAbcissa, which is True for all but first spectrum (!first is passed). As a result a change in reference value is ignored.
We also have to relax the condition in lines 1752-1756, which currently throws an exception if the input and output reference frames are the same. They could be the same, but with different reference values/increments/reference pixels.