Opened 11 years ago
Closed 11 years ago
#187 closed defect (fixed)
Results file has lost the Z_peak column
| Reported by: | MatthewWhiting | Owned by: | MatthewWhiting |
|---|---|---|---|
| Priority: | high | Milestone: | Release-1.3.1 |
| Component: | Output | Version: | 1.3 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
In the duchamp-Results.txt file, we don't have the Z_peak column - only the X_peak and Y_peak. Perhaps an indexing problem with the columns?
It appears in the XML/VOTable output.
Change History (4)
comment:1 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 11 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Still need to update all the verification scripts to account for this, so reopening.
comment:3 Changed 11 years ago by
Verification scripts weren't catching it! While the logfile tests do a full diff, the results file tests just look at the ID,X,Y,Z columns. What's more, the standard results from D1.3 had the Z_PEAK missing anyway, so there would have been nothing to catch (this came about when I incorporated the MAJ/MIN/PA columns - obviously missed the fact that the Z_PEAK column had been dropped.
comment:4 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Have updated this for all tests other than number 3 - this will be handled with #188.
Have also changed the verification script so that it does a full check, rather than the more limited one it was doing before.
Closing this.
Problem lay in the Column::doCol function, where we assign columns according to the table type. There was an incorrect value for one of the loops, meaning the last option for the FileList? was never read - this was ZPEAK...
Fixed now, with slight improvement to the code.