Results file has lost the Z_peak column

[MatthewWhiting]

In the duchamp-Results.txt file, we don't have the Z_peak column - only the X_peak and Y_peak. Perhaps an indexing problem with the columns?

It appears in the XML/VOTable output.

[MatthewWhiting]

Problem lay in the Column::doCol function, where we assign columns according to the table type. There was an incorrect value for one of the loops, meaning the last option for the FileList? was never read - this was ZPEAK...

Fixed now, with slight improvement to the code.

[MatthewWhiting]

Still need to update all the verification scripts to account for this, so reopening.

[MatthewWhiting]

Verification scripts weren't catching it! While the logfile tests do a full diff, the results file tests just look at the ID,X,Y,Z columns. What's more, the standard results from D1.3 had the Z_PEAK missing anyway, so there would have been nothing to catch (this came about when I incorporated the MAJ/MIN/PA columns - obviously missed the fact that the Z_PEAK column had been dropped.

[MatthewWhiting]

Have updated this for all tests other than number 3 - this will be handled with #188.

Have also changed the verification script so that it does a full check, rather than the more limited one it was doing before.

Closing this.