Opened 19 years ago

Closed 18 years ago

#25 closed enhancement (fixed)

gripes about create_mask

Reported by: Tony.Wong@… Owned by: Chris Phillips
Priority: lowest Milestone: ASAP 2.2
Component: Documentation Version: 2.0
Severity: normal Keywords:
Cc: Tony.Wong@…

Description

I still find it impossible to remember that "invert=true" in create_mask sets the channels to be excluded. I would really prefer if this was changed to something like "flag=false" which is what is used in MIRIAD immask. It would also be nice to be able to specify the units as an argument to create_mask.

Change History (12)

comment:1 by Malte Marquarding, 19 years ago

Owner: changed from Malte Marquarding to Chris Phillips
Severity: normalenhancement

Hi Tony, this has been "surveyed" before and it turned out that there was no majority either way.

I don't think this can be changed as some people are already using it this way in scripts, but will leave this decision to Chris.

comment:2 by Malte Marquarding, 19 years ago

Cc: Tony.Wong@… added
Priority: normallowest

comment:3 by Chris Phillips, 19 years ago

Milestone: ASAP2 releaseASAP 2.1

Tony. It is not clear to me whether you are concerned about the default meaning of the mask/flag values or it is just the name of the "invert" option you object to. Do you often use the "invert" option? As this is minor we can address before 2.1 release (if anything is done I am not sure it is worth it).

comment:4 by tony.wong@…, 19 years ago

I guess I just find it impossible to remember how to use the "invert" keyword. I would like to eventually move beyond constantly looking at the Users Guide, after all. A more intuitive keyword, like mode=[include|exclude] would help.

comment:5 by Chris Phillips, 18 years ago

Milestone: ASAP 2.1ASAP 2.2
Status: newassigned

We may add a mode=[include|exclude] alias for the 2.2 release. The current behaviour make sense. The wording can be changed but best not at this stage. Mask is an issue I want to review for the 2.2 release so better to make changes then if they happen.

comment:6 by William, 18 years ago

Component: GeneralDocumentation
Summary: gripes about create_masksmart+question

comment:11 by bugs, 18 years ago

Summary: smart+questiongripes about create_mask

comment:12 by Malte Marquarding, 18 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.