Opened 14 years ago

Closed 14 years ago

#192 closed defect (fixed)

Create Abstract Filler class

Reported by: Malte Marquarding Owned by: Malte Marquarding
Priority: high Milestone:
Component: c++ Version: 2.0
Severity: critical Keywords:
Cc: Takeshi Nakazato

Description (last modified by Malte Marquarding)

At the 2010 developer workshop we decided to abstract the way the STFiller works so readers other than PKSreader can be used.

Implement this in the merged trunk.

Change History (7)

comment:1 Changed 14 years ago by Malte Marquarding

Description: modified (diff)
Owner: changed from Malte Marquarding to Malte Marquarding
Status: new → assigned

comment:2 Changed 14 years ago by Malte Marquarding

We will be creating:

  • Filler.h - the access class from python
  • FillerBase?.h - the abstraction of the filler
  • PKSFiller.h - the PKSreader based filler
  • NROFiller.h - Filler for Nobeyama data.

comment:3 Changed 14 years ago by Malte Marquarding

These have been committed to source:branches/newfiller/​

comment:4 Changed 14 years ago by anonymous

We need to be able to pass filler specific data down to the implementations. The best way is using dicts but we have to wait for Wes to add building of libpyrap to the casapy cmake scripts.

comment:5 Changed 14 years ago by Malte Marquarding

This has been committed.

The PKSFiller implementation is working locally and just has to be verified against casapy.

comment:6 Changed 14 years ago by Takeshi Nakazato

I committed NROFiller a few days ago. Today, I committed test data and script for NROFiller in test directory. The test is quite primitive and trivial...

comment:7 Changed 14 years ago by Malte Marquarding

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.