Changeset 3080

Timestamp:

11/25/15 15:49:41 (9 years ago)

Author:

Takeshi Nakazato

Message:

New Development: No

JIRA Issue: No

Ready for Test: Yes

Interface Changes: Yes/No

What Interface Changed: Please list interface changes

Test Programs: List test programs

Put in Release Notes: Yes/No

Module(s): Module Names change impacts.

Description: Describe your changes here...

Bug fix on index range check. It seems that current code allows index 4. But I think valid index range should be 0 <= index <= 4.

Location:

trunk/src

Files:

• STPolCircular.cpp (modified) (1 diff)
• STPolLinear.cpp (modified) (2 diffs)
• STPolStokes.cpp (modified) (1 diff)

trunk/src/STPolCircular.cpp

@@ -46 +46 @@
     throw(AipsError("You must have 4 circular polarisations to run this function"));
   }
-  if ( index < 0 || index >4 ) throw(AipsError("LinPol index out of range"));
+//  if ( index < 0 || index >4 ) throw(AipsError("LinPol index out of range"));
+  if ( index >= 4 ) throw(AipsError("LinPol index out of range"));
   Vector<Float> out,q,u;
   if ( nspec() == 4) {

trunk/src/STPolLinear.cpp

@@ -30 +30 @@
 Vector<Float> asap::STPolLinear::getStokes( uint index )
 {
-  if ( index > 4 ) throw(AipsError("Stokes index out of range"));
+  if ( index >= 4 ) throw(AipsError("Stokes index out of range"));
   Vector<Float> out;
   Float phase = getTotalPhase();
@@ -61 +61 @@
     throw(AipsError("You must have 4 linear polarizations to run this function"));
   }
-  if ( index >4 ) throw(AipsError("LinPol index out of range"));
+  if ( index >= 4 ) throw(AipsError("LinPol index out of range"));
   Vector<Float> out,q,u;
   if ( nspec() == 4) {

trunk/src/STPolStokes.cpp

@@ -35 +35 @@
 Vector<Float> asap::STPolStokes::getLinPol( uInt index )
 {
-  if ( index < 0 || index >4 ) throw(AipsError("LinPol index out of range"));
+//  if ( index < 0 || index >4 ) throw(AipsError("LinPol index out of range"));
+  if ( index >= 4 ) throw(AipsError("LinPol index out of range"));
   Vector<Float> out;
   if ( nspec() == 4) {