Changeset 2094 for trunk/src/Scantable.cpp

Timestamp:

04/01/11 21:36:20 (13 years ago)

Author:

WataruKawasaki

Message:

New Development: No

JIRA Issue: No

Ready for Test: Yes

Interface Changes: No

What Interface Changed:

Test Programs:

Put in Release Notes: No

Module(s): Scantable

Description: minor bugfix/cleanup.

File:

• trunk/src/Scantable.cpp (modified) (14 diffs)

trunk/src/Scantable.cpp

@@ -1775 +1775 @@
 }
 
-void Scantable::polyBaseline(const std::vector<bool>& mask, int order, bool outLogger, const std::string& blfile)
+void Scantable::polyBaseline(const std::vector<bool>& mask, int order, bool getResidual, bool outLogger, const std::string& blfile)
 {
   ofstream ofs;
@@ -1803 +1803 @@
     chanMask = getCompositeChanMask(whichrow, mask);
     fitBaseline(chanMask, whichrow, fitter);
-    setSpectrum(fitter.getResidual(), whichrow);
+    setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
     outputFittingResult(outLogger, outTextFile, chanMask, whichrow, coordInfo, hasSameNchan, ofs, "polyBaseline()", fitter);
   }
@@ -1810 +1810 @@
 }
 
-void Scantable::autoPolyBaseline(const std::vector<bool>& mask, int order, const std::vector<int>& edge, float threshold, int chanAvgLimit, bool outLogger, const std::string& blfile)
+void Scantable::autoPolyBaseline(const std::vector<bool>& mask, int order, const std::vector<int>& edge, float threshold, int chanAvgLimit, bool getResidual, bool outLogger, const std::string& blfile)
 {
   ofstream ofs;
@@ -1864 +1864 @@
 
     fitBaseline(chanMask, whichrow, fitter);
-    setSpectrum(fitter.getResidual(), whichrow);
+    setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
 
     outputFittingResult(outLogger, outTextFile, chanMask, whichrow, coordInfo, hasSameNchan, ofs, "autoPolyBaseline()", fitter);
@@ -1872 +1872 @@
 }
 
-void Scantable::cubicSplineBaseline(const std::vector<bool>& mask, int nPiece, float thresClip, int nIterClip, bool outLogger, const std::string& blfile)
+void Scantable::cubicSplineBaseline(const std::vector<bool>& mask, int nPiece, float thresClip, int nIterClip, bool getResidual, bool outLogger, const std::string& blfile)
 {
   ofstream ofs;
@@ -1900 +1900 @@
     chanMask = getCompositeChanMask(whichrow, mask);
     //fitBaseline(chanMask, whichrow, fitter);
-    //setSpectrum(fitter.getResidual(), whichrow);
+    //setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
     std::vector<int> pieceEdges;
     std::vector<float> params;
-    std::vector<float> res = doCubicSplineFitting(getSpectrum(whichrow), chanMask, nPiece, pieceEdges, params, thresClip, nIterClip, true);
+    std::vector<float> res = doCubicSplineFitting(getSpectrum(whichrow), chanMask, nPiece, pieceEdges, params, thresClip, nIterClip, getResidual);
     setSpectrum(res, whichrow);
     //
@@ -1913 +1913 @@
 }
 
-void Scantable::autoCubicSplineBaseline(const std::vector<bool>& mask, int nPiece, float thresClip, int nIterClip, const std::vector<int>& edge, float threshold, int chanAvgLimit, bool outLogger, const std::string& blfile)
+void Scantable::autoCubicSplineBaseline(const std::vector<bool>& mask, int nPiece, float thresClip, int nIterClip, const std::vector<int>& edge, float threshold, int chanAvgLimit, bool getResidual, bool outLogger, const std::string& blfile)
 {
   ofstream ofs;
@@ -1968 +1968 @@
 
     //fitBaseline(chanMask, whichrow, fitter);
-    //setSpectrum(fitter.getResidual(), whichrow);
+    //setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
     std::vector<int> pieceEdges;
     std::vector<float> params;
-    std::vector<float> res = doCubicSplineFitting(getSpectrum(whichrow), chanMask, nPiece, pieceEdges, params, thresClip, nIterClip, true);
+    std::vector<float> res = doCubicSplineFitting(getSpectrum(whichrow), chanMask, nPiece, pieceEdges, params, thresClip, nIterClip, getResidual);
     setSpectrum(res, whichrow);
     //
@@ -1987 +1987 @@
   }
   if (nPiece < 1) {
-    throw(AipsError("wrong number of the sections for fitting"));
+    throw(AipsError("number of the sections must be one or more"));
   }
 
@@ -2229 +2229 @@
     chanMask = getCompositeChanMask(whichrow, mask);
     //fitBaseline(chanMask, whichrow, fitter);
-    //setSpectrum(fitter.getResidual(), whichrow);
+    //setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
     std::vector<float> params;
-    //std::vector<float> res = doSinusoidFitting(getSpectrum(whichrow), chanMask, nWaves, params, thresClip, nIterClip, true);
     std::vector<float> res = doSinusoidFitting(getSpectrum(whichrow), chanMask, nWaves, maxWaveLength, params, thresClip, nIterClip, getResidual);
     setSpectrum(res, whichrow);
@@ -2297 +2296 @@
 
     //fitBaseline(chanMask, whichrow, fitter);
-    //setSpectrum(fitter.getResidual(), whichrow);
+    //setSpectrum((getResidual ? fitter.getResidual() : fitter.getFit()), whichrow);
     std::vector<float> params;
     std::vector<float> res = doSinusoidFitting(getSpectrum(whichrow), chanMask, nWaves, maxWaveLength, params, thresClip, nIterClip, getResidual);
@@ -2349 +2348 @@
 
   const double PI = 6.0 * asin(0.5); // PI (= 3.141592653...)
-  double baseXFactor = 2.0*PI/(double)maxWaveLength/(double)(nChan-1);  //the denominator (nChan-1) should be changed to (xdata[nChan-1]-xdata[0]) for accepting x-values given in velocity or frequency when this function is moved to fitter.
+  double baseXFactor = 2.0*PI/(double)maxWaveLength/(double)(nChan-1);  //the denominator (nChan-1) should be changed to (xdata[nChan-1]-xdata[0]) for accepting x-values given in velocity or frequency when this function is moved to fitter. (2011/03/30 WK)
 
   // xArray : contains elemental values for computing the least-square matrix. 
@@ -2649 +2648 @@
 
   if (verbose) {
-    for (int i = 0; i < 60; ++i) {
-      oss << "-";
-    }
-    oss << endl;
     oss <<  " Scan[" << getScan(whichrow)  << "]";
     oss <<  " Beam[" << getBeam(whichrow)  << "]";
@@ -2673 +2668 @@
     oss << "Results of baseline fit" << endl;
     oss << "  rms = " << setprecision(6) << rms << endl;
+    for (int i = 0; i < 60; ++i) {
+      oss << "-";
+    }
+    oss << flush;
   }