#148 closed enhancement (fixed)
Output from 1D searching not very useful
Reported by: | MatthewWhiting | Owned by: | MatthewWhiting |
---|---|---|---|
Priority: | normal | Milestone: | Release-1.2 |
Component: | Output | Version: | 1.1.13 |
Severity: | normal | Keywords: | |
Cc: |
Description (last modified by )
We advertise that Duchamp works fine for 1D spectra, but the output is not really good enough:
- The final catalogue lists the channels in the X-column, rather than the Z (which is what you'd expect).
- The RA/DEC calculations appear confused.
- The spectra output appears to use the 2D case, plotting a map of the spectrum (ie. as a line of pixels) when it should plot the spectrum.
In short, the 1D processing just seems to be a special case of the 2D processing, albeit with the 1D search. Work needs to be done specialising the handling of the search results for the 1D case.
Change History (6)
comment:1 Changed 12 years ago by
Status: | new → assigned |
---|---|
Summary: | 1D searching not very useful → Output from 1D searching not very useful |
comment:2 Changed 12 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 12 years ago by
comment:4 Changed 12 years ago by
The first part of this is done in [977] and [978], making it a mock 3D cube. This results in the searching returning z-values instead of x-values, which is what we want.
Now have to adapt the graphical output.
There is still an error with a double free occuring at the end of the execution -- this needs to be followed up.
comment:5 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This is now greatly improved. The graphical output now consists of a spectrum with each final detection highlighted, as well as a bar along the top indicating which channels were detected (including those rejected for failing the minimum criteria).
I've also put the detection and growth thresholds so you can easily see what is detected and what was just missed. (These have also been added to the regular spectral output, at least for the peak flux spectra.)
Closing this ticket, but might make another one to improve the formatting of the plots, as well as the class design for the relevant code.
comment:6 Changed 9 years ago by
Pluto's weather is more active than we thought With each batch of images that rolls in from New Horizons, scientists learn more about Pluto's characteristics.
Here's what should happen in the 1D case: