Opened 15 years ago

Closed 14 years ago

#93 closed enhancement (fixed)

new task: pgflag

Reported by: VincentMcIntyre Owned by: JamieStevens
Priority: major Milestone:
Component: MIRIAD - CABB branch Version:
Keywords: flagging Cc: Jamie.Stevens@…
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0

Description

JamieStevens? suggests a new task for 'tv-style' flagging would be worth the effort.

Specification at Development/cabb-upgrade/PGFLAG

Change History (9)

comment:1 Changed 15 years ago by VincentMcIntyre

Owner: changed from MarkWieringa to JamieStevens

comment:2 Changed 15 years ago by JamieStevens

Status: newassigned

Version 1 of PGFLAG is now ready for testing, in the CABB-MIRIAD branch (added there by Mark Wieringa).

It is functional to the level that I wanted to begin with, but it has plenty of scope for further functionality. Feedback on usability and desired functions is requested.

comment:3 Changed 15 years ago by JamieStevens

Version 1.3 released on Oct 7 2009.

Changelog:

  • fixed a format bug that showed up when compiled with g77 instead of gfortran
  • added average subtraction ability - can now subtract the time average or channel average from the displayed data
  • colour amplitude scaling can be fiddled with the mouse, or set from the currently viewed data, or set from the currently selected region, and fixed for all baselines
  • added "are you sure" questions when quitting or aborting
  • fixed bug in time flagging selection region
  • added consistency checks for usability
  • now computes and displays a summary of good/bad data and changed flags at quit, similar to uvflag
  • can flag region for all baselines containing displayed antenna 1 or 2
  • can throw away all flags applying to the currently displayed baseline, or all baselines, without having to quit PGFLAG

Further feedback on usability and functions is requested.

comment:4 Changed 14 years ago by VincentMcIntyre

2009-12-08

merged to mainline.

% mirtree
% cd miriad/prog
% co -l -r pgflag.for
% cp /nfs/atapplic/miriad-cabb/prog/pgflag.for
% ci -u -m"merged to mainline from cabb branch" pgflag.for

comment:5 Changed 14 years ago by VincentMcIntyre

2009-12-09

didn't go perfectly.

  1. linux version did not build (but linux64 did)

It appears the target worked, but there is no binary.

linux:

gmake[0]: make -C prog
Tue 2009/12/08 22:00:07 +1100, executing on draco
        pgflag.for 1.3

linux64:

gmake[0]: make -C prog
Tue 2009/12/08 22:15:07 +1100, executing on delphinus

Updating dependencies for pgflag.for
/nfs/atapplic/miriad/linux64/bin/ratty -b -s linux -I /nfs/atapplic/miriad/prog 
-I /nfs/atapplic/miriad/inc/linux64 -I /nfs/atapplic/miriad/inc pgflag.for /nfs/
atapplic/miriad/linux64/tmp/pgflag.f
Number of lines = 3841; number of routines = 26
f77 -O0 -ff90-intrinsics-hide -fPIC  -o /nfs/atapplic/miriad/linux64/bin/pgflag 
/nfs/atapplic/miriad/linux64/tmp/pgflag.f /nfs/atapplic/miriad/linux64/lib/libmi
r.a /nfs/atapplic/miriad/linux64/lib/librpfits.a -L/nfs/atapplic/miriad/linux64/
lib -llinpack -lpgplot -lpng -lz -L/usr/X11R6/lib -lX11 -lm
/nfs/atapplic/miriad/linux64/bin/doc -f pgflag.for > /nfs/atapplic/miriad/doc/pg
flag.doc

  1. solaris compilation error.
    Updating dependencies for pgflag.for
    /nfs/atapplic/miriad/sun4sol/bin/ratty -b -s sun -I /nfs/atapplic/miriad/prog  
    -I /nfs/atapplic/miriad/inc pgflag.for /nfs/atapplic/miriad/sun4sol/tmp/pgflag.
    f
    Number of lines = 3781; number of routines = 26
    f77 -O2 -libmil  -u  -o /nfs/atapplic/miriad/sun4sol/bin/pgflag 
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f /nfs/atapplic/miriad/sun4sol/lib/libm
    ir.a /nfs/atapplic/miriad/sun4sol/lib/librpfits.a -L/nfs/atapplic/miriad/sun4so
    l/lib -llinpack -lpgplot -lpng -lz -L/usr/openwin/lib -lX11 -nolib -Bstatic 
    -lF77 -lM77 -lsunmath -Bdynamic -lsocket -lnsl -lm -lcx -lc
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f:
     MAIN pgflag:
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 510: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 550: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 610: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 856: Error: unclassifiable 
    Updating dependencies for pgflag.for
    /nfs/atapplic/miriad/sun4sol/bin/ratty -b -s sun -I /nfs/atapplic/miriad/prog  
    -I /nfs/atapplic/miriad/inc pgflag.for /nfs/atapplic/miriad/sun4sol/tmp/pgflag.
    f
    Number of lines = 3781; number of routines = 26
    f77 -O2 -libmil  -u  -o /nfs/atapplic/miriad/sun4sol/bin/pgflag 
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f /nfs/atapplic/miriad/sun4sol/lib/libm
    ir.a /nfs/atapplic/miriad/sun4sol/lib/librpfits.a -L/nfs/atapplic/miriad/sun4so
    l/lib -llinpack -lpgplot -lpng -lz -L/usr/openwin/lib -lX11 -nolib -Bstatic 
    -lF77 -lM77 -lsunmath -Bdynamic -lsocket -lnsl -lm -lcx -lc
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f:
     MAIN pgflag:
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 510: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 550: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 610: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 856: Error: unclassifiable 
    Updating dependencies for pgflag.for
    /nfs/atapplic/miriad/sun4sol/bin/ratty -b -s sun -I /nfs/atapplic/miriad/prog  
    -I /nfs/atapplic/miriad/inc pgflag.for /nfs/atapplic/miriad/sun4sol/tmp/pgflag.
    f
    Number of lines = 3781; number of routines = 26
    f77 -O2 -libmil  -u  -o /nfs/atapplic/miriad/sun4sol/bin/pgflag 
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f /nfs/atapplic/miriad/sun4sol/lib/libm
    ir.a /nfs/atapplic/miriad/sun4sol/lib/librpfits.a -L/nfs/atapplic/miriad/sun4so
    l/lib -llinpack -lpgplot -lpng -lz -L/usr/openwin/lib -lX11 -nolib -Bstatic 
    -lF77 -lM77 -lsunmath -Bdynamic -lsocket -lnsl -lm -lcx -lc
    /nfs/atapplic/miriad/sun4sol/tmp/pgflag.f:
     MAIN pgflag:
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 510: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 550: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 610: Error: unclassifiable 
    statement
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 856: Error: unclassifiable 
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 856: Error: unclassifiable 
    statement
            writeflags:
            locatemax:
            applyflags:
            flagdata:
            reset_points:
            makemeasurement:
            makeplot:
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 2114: Error: unclassifiable 
    statement
            paint_plot:
            draw_waterfall:
            mask_and_range:
            set_plot_main:
            compute_average_spectrum:
            set_plot_top_info:
            gridit:
            getaxis:
            getopt:
            getdat:
            intflush:
            getval:
            flagchk:
            copydat:
            ctoapri:
            julian_to_date:
            fmtcmd:
    "/nfs/atapplic/miriad/sun4sol/tmp/pgflag.f", line 3688: Error: unclassifiable 
    statement
            monthstring:
    gmake[1]: [/nfs/atapplic/miriad/sun4sol/bin/pgflag] Error 1 (ignored)
    nm: /nfs/atapplic/miriad/sun4sol/bin/pgflag: No such file or directory
    strip: /nfs/atapplic/miriad/sun4sol/bin/pgflag: cannot open file.
            No such file or directory
    gmake[1]: [/nfs/atapplic/miriad/sun4sol/bin/pgflag] Error 1 (ignored)
    chmod: cannot access `/nfs/atapplic/miriad/sun4sol/bin/pgflag': No such file 
    or directory
    gmake[1]: [/nfs/atapplic/miriad/sun4sol/bin/pgflag] Error 1 (ignored)
    

comment:6 in reply to:  5 Changed 14 years ago by VincentMcIntyre

Replying to VincentMcIntyre:

worked on darwin_x86.

comment:7 Changed 14 years ago by VincentMcIntyre

2009-12-10

The linux build worked, without me changing anything.

gmake[0]: make -C prog
Wed 2009/12/09 22:00:09 +1100, executing on draco

Updating dependencies for pgflag.for
/nfs/atapplic/miriad/linux/bin/ratty -b -s linux -I /nfs/atapplic/miriad/prog
-I /nfs/atapplic/miriad/inc pgflag.for /nfs/atapplic/miriad/linux/tmp/pgflag.f
Number of lines = 3781; number of routines = 26
/usr/bin/g77-3.4 -O -fPIC -ff90-intrinsics-hide -Wimplicit -Wunused  
-o /nfs/atapplic/miriad/linux/bin/pgflag /nfs/atapplic/miriad/linux/tmp/pgflag.f
 /nfs/atapplic/miriad/linux/lib/libmir.a /nfs/atapplic/miriad/linux/lib/librpfits.a
-L/nfs/atapplic/miriad/linux/lib -llinpack -lpgplot -lpng -lz -L/usr/X11R6/lib -lX11 -lm


comment:8 Changed 14 years ago by VincentMcIntyre

2010-02-03

pgflag is now building ok on solaris, last update to the binary was on 2009-12-15. I think this ticket can be closed.

comment:9 Changed 14 years ago by JamieStevens

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.