Opened 16 years ago

Closed 15 years ago

#64 closed defect (fixed)

versan: change argument list

Reported by: VincentMcIntyre Owned by: MarkCalabretta
Priority: major Milestone:
Component: MIRIAD - main line Version:
Keywords: Cc:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0

Description (last modified by VincentMcIntyre)

The version string printed by miriad programs is computed by the versan subroutine.

This is fed a program name and an RCS $Id$ string as input. This breaks in some cases, because the Id string becomes longer than 80 characters (code won't compile).

This can be resolved by feeding the versan subroutine the $Revision$ and $Date$ RCS tags as arguments, instead of $Id$. This has the advantage of providing cleaner input, thus reducing the amount of parsing versan has to do, and not causing the compilation problems noted above.

For atlod the patch looks like:

--- /nfs/atapplic/miriad/prog/atlod.for 2008-05-30 22:00:13.149997000 +1000
+++ atlod.for   2008-06-20 12:39:24.319107000 +1000
@@ -264,7 +264,8 @@
        character itoaf*8, rperr*32, versan*80
 c-----------------------------------------------------------------------
       version = versan ('atlod',
-     :  '$Id: atlod.for,v 1.6 2007/10/23 22:08:41 wie017 Exp $')
+     :  '$Revision$',
+     :  '$Date$')
 c
 c  Get the input parameters.
 c

At present this affects about 26 tasks in miriad, and subs/versan.for.

Change History (2)

comment:1 Changed 16 years ago by VincentMcIntyre

Description: modified (diff)

comment:2 Changed 15 years ago by MarkCalabretta

Resolution: fixed
Status: newclosed

Modified VERSAN as suggested and updated 35 tasks.

Note: See TracTickets for help on using tickets.