Opened 14 years ago

Closed 14 years ago

#76 closed defect (fixed)

MW ranges do not adjust for subsection

Reported by: MatthewWhiting Owned by: MatthewWhiting
Priority: normal Milestone: Release-1.1.9
Component: FITS reader Version: 1.1.8
Severity: normal Keywords:
Cc:

Description

The MW range (minMW - maxMW) are always treated as channels in the array *as loaded*. So, if you specify a channel range in the subsection, the offset in channels is *not* taken into account.

Example: For the HIPASS cubes, I have a standard minMW=75 and maxMW=112. But if I use a subsection with, say, a channel range 112:1024, the MW channels are still applied.

The expected behaviour would be that the offset (112) would be removed from the MW range, so that minMW,maxMW would become -37,0.

Change History (4)

comment:1 Changed 14 years ago by MatthewWhiting

Status: newassigned

comment:2 Changed 14 years ago by MatthewWhiting

Best way might be to encapsulate this in the Param::getMinMW() and Param::getMaxMW() functions, where the subsection offset is simply subtracted from the provided parameter. This is the only way these values are obtained, except for the Param::isInMW() function, which should be changed accordingly.

Also need to add to the documentation, to make it explicit that the minMW/maxMW values refer to the *complete* cube.

comment:3 Changed 14 years ago by MatthewWhiting

Done in [673]. Had to alter the param reporting function to remove the offset correction, as we want to report the parameters as entered.

Closing ticket.

comment:4 Changed 14 years ago by MatthewWhiting

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.