#
# ChangeLog for trunk
#
# Generated by Trac 1.2.3
# 05/15/24 05:05:34

Fri, 13 Mar 2009 00:53:48 GMT Malte Marquarding [1524]
	* trunk/doc/CHANGELOG (modified)

	update


Fri, 13 Mar 2009 00:52:52 GMT Malte Marquarding [1523]
	* trunk/python/__init__.py (modified)

	change version for release


Fri, 20 Feb 2009 01:18:48 GMT Malte Marquarding [1513]
	* trunk/python/__init__.py (modified)
	* trunk/python/asaplotbase.py (modified)

	added rc parameter tp control ax-axis formatting


Fri, 20 Feb 2009 01:08:12 GMT Malte Marquarding [1512]
	* trunk/python/scantable.py (modified)

	fixed typo in get_spectrum args


Wed, 18 Feb 2009 05:21:33 GMT Malte Marquarding [1511]
	* trunk/SConstruct (modified)

	added  ipy_user_config.py to makedist target


Wed, 18 Feb 2009 04:15:57 GMT Malte Marquarding [1510]
	* trunk/src/STFITSImageWriter.cpp (modified)

	Ticket #110: export velocity if restfreq is given otherwise ...


Wed, 18 Feb 2009 04:08:26 GMT Malte Marquarding [1509]
	* trunk/external/atnf/PKSIO/SDFITSreader.cc (modified)

	make gcc-4.3 compliant; Mark C. still needs to fix char* cast ...


Wed, 18 Feb 2009 01:00:17 GMT Malte Marquarding [1508]
	* trunk/python/__init__.py (modified)

	added st_sourcetype to list of commands


Mon, 16 Feb 2009 06:19:31 GMT Max Voronkov [1507]
	* trunk/src/Scantable.cpp (modified)

	fixed typo in the exception text


Fri, 13 Feb 2009 00:29:40 GMT Malte Marquarding [1506]
	* trunk/doc/CHANGELOG (modified)

	update from ticket fixes


Fri, 13 Feb 2009 00:28:39 GMT Malte Marquarding [1505]
	* trunk/src/STMath.cpp (modified)

	use addRow before copyRows consistently; tidy up of getScantable


Fri, 13 Feb 2009 00:27:42 GMT Malte Marquarding [1504]
	* trunk/python/__init__.py (modified)
	* trunk/python/scantable.py (modified)
	* trunk/src/STFiller.cpp (modified)
	* trunk/src/STFiller.h (modified)
	* trunk/src/python_STFiller.cpp (modified)

	Fix for ticket #151: added facilities to help with on/off scan ...


Thu, 12 Feb 2009 09:12:45 GMT Malte Marquarding [1503]
	* trunk/src/Scantable.cpp (modified)

	Fix for ticket #78; this had nothing to do with memory tables, it was ...


Thu, 12 Feb 2009 08:58:01 GMT Malte Marquarding [1502]
	* trunk/python/scantable.py (modified)

	added function to set reference scans manually


Wed, 11 Feb 2009 01:54:51 GMT Malte Marquarding [1501]
	* trunk/SConstruct (modified)
	* trunk/src/python_asap.cpp (modified)

	support linking against pyrap


Tue, 10 Feb 2009 02:17:31 GMT Malte Marquarding [1500]
	* trunk/src/STFITSImageWriter.cpp (modified)
	* trunk/src/STFITSImageWriter.h (modified)

	Fix for ticket #110. Hopefully the last. Using the preferVelocity ...


Sun, 08 Feb 2009 23:42:52 GMT Malte Marquarding [1499]
	* trunk/INSTALL (modified)
	* trunk/doc/userguide.tex (modified)

	updates fro next release


Wed, 04 Feb 2009 06:42:20 GMT Max Voronkov [1497]
	* trunk/doc/CHANGELOG (modified)
	* trunk/src/STLineFinder.cpp (modified)

	fixed #149. The problem was inside getMask method. In some rare ...


Wed, 21 Jan 2009 05:14:37 GMT Malte Marquarding [1488]
	* trunk/doc/CHANGELOG (modified)

	fixed typo


Wed, 21 Jan 2009 05:03:18 GMT Malte Marquarding [1487]
	* trunk/test/file-io.py (modified)

	rename sdfits as inconsistent with other outputs


Wed, 21 Jan 2009 02:31:59 GMT Max Voronkov [1486]
	* trunk/doc/CHANGELOG (modified)

	ticket #142 mentioned in changelog


Tue, 20 Jan 2009 09:13:21 GMT Malte Marquarding [1485]
	* trunk/doc/CHANGELOG (modified)

	more updates for upcoming 2.3 release


Tue, 20 Jan 2009 09:12:54 GMT Malte Marquarding [1484]
	* trunk/src/STMath.cpp (modified)

	Fix for Ticket #148; forgot to scale TSYS


Tue, 20 Jan 2009 09:12:02 GMT Malte Marquarding [1483]
	* trunk/python/scantable.py (modified)

	added flag_nans to help with possible non-flagged NaNs in the data


Sat, 17 Jan 2009 08:04:12 GMT Max Voronkov [1481]
	* trunk/src/STWeather.cpp (modified)
	* trunk/src/STWeather.h (modified)

	restored proper constness for STWeather::getEntry. No change in ...


Fri, 16 Jan 2009 05:07:28 GMT Malte Marquarding [1479]
	* trunk/python/asaplotbase.py (modified)

	fix some matplotlib deprecation warnings


Fri, 16 Jan 2009 04:54:47 GMT Malte Marquarding [1478]
	* trunk/test/file-io.py (modified)

	chnaged output filename prefix add FITS and CLASSFITS to tests


Fri, 16 Jan 2009 04:51:16 GMT Malte Marquarding [1477]
	* trunk/src/STWriter.cpp (modified)

	fixed unititialised vector length vor convertArray


Fri, 16 Jan 2009 04:49:58 GMT Malte Marquarding [1476]
	* trunk/src/STFITSImageWriter.cpp (modified)

	removed debug cout


Fri, 16 Jan 2009 04:03:06 GMT Max Voronkov [1475]
	* trunk/src/STMath.cpp (modified)

	fixed frequency alignment problem (#142). Different FREQ_IDs are now ...


Thu, 15 Jan 2009 01:27:16 GMT Malte Marquarding [1474]
	* trunk/doc/CHANGELOG (modified)

	details for release 2.3.0


Thu, 15 Jan 2009 01:16:32 GMT Malte Marquarding [1473]
	* trunk/COPYING (modified)

	update date


Thu, 15 Jan 2009 01:16:08 GMT Malte Marquarding [1472]
	* trunk/python/__init__.py (modified)

	allow upgrade of ipython rc


Thu, 15 Jan 2009 01:10:40 GMT Malte Marquarding [1471]
	* trunk/python/__init__.py (modified)
	* trunk/python/scantable.py (modified)

	added publich get/set_spectrum functions


Thu, 15 Jan 2009 01:06:23 GMT Malte Marquarding [1470]
	* trunk/share/ipy_user_conf.py (modified)

	execute userfuncs


Thu, 15 Jan 2009 01:06:00 GMT Malte Marquarding [1469]
	* trunk/SConstruct (modified)

	add ipy_user_conf.py to installed files


Wed, 14 Jan 2009 04:52:59 GMT Malte Marquarding [1468]
	* trunk/src/STFITSImageWriter.cpp (modified)

	removed debug cout


Wed, 14 Jan 2009 04:44:07 GMT Malte Marquarding [1467]
	* trunk/src/STFiller.cpp (modified)

	fix for cast from double to float in scanrate field


Wed, 14 Jan 2009 03:29:20 GMT Malte Marquarding [1466]
	* trunk/external/atnf/PKSIO/PKSmsg.cc (modified)
	* trunk/external/atnf/PKSIO/SDFITSwriter.cc (modified)

	make gcc-4.3 compliant; Mark C. still needs to fix char* cast ...


Wed, 14 Jan 2009 02:52:57 GMT Malte Marquarding [1465]
	* trunk/scons/utils.py (modified)

	add WalkDirTree which is erequired for data dir installs


Wed, 14 Jan 2009 01:32:14 GMT Malte Marquarding [1464]
	* trunk/SConstruct (modified)

	require scons>=1.1


Wed, 14 Jan 2009 01:25:41 GMT Malte Marquarding [1463]
	* trunk/INSTALL (modified)

	updated dependencies


Wed, 14 Jan 2009 01:25:25 GMT Malte Marquarding [1462]
	* trunk/src/STFiller.cpp (modified)
	* trunk/src/STWriter.cpp (modified)

	change in PKSIO api


Wed, 19 Nov 2008 09:41:16 GMT Malte Marquarding [1452]
	* trunk/external/atnf/PKSIO/FITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/FITSreader.h (modified)
	* trunk/external/atnf/PKSIO/MBFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/MBFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/MBrecord.cc (added)
	* trunk/external/atnf/PKSIO/MBrecord.h (added)
	* trunk/external/atnf/PKSIO/PKSFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSMBrecord.cc (deleted)
	* trunk/external/atnf/PKSIO/PKSMBrecord.h (deleted)
	* trunk/external/atnf/PKSIO/PKSMS2reader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMS2reader.h (modified)
	* trunk/external/atnf/PKSIO/PKSMS2writer.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMS2writer.h (modified)
	* trunk/external/atnf/PKSIO/PKSSDwriter.cc (modified)
	* trunk/external/atnf/PKSIO/PKSSDwriter.h (modified)
	* trunk/external/atnf/PKSIO/PKSmsg.cc (added)
	* trunk/external/atnf/PKSIO/PKSmsg.h (added)
	* trunk/external/atnf/PKSIO/PKSreader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSrecord.h (added)
	* trunk/external/atnf/PKSIO/PKSwriter.h (modified)
	* trunk/external/atnf/PKSIO/SDFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/SDFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/SDFITSwriter.cc (modified)
	* trunk/external/atnf/PKSIO/SDFITSwriter.h (modified)
	* trunk/external/atnf/PKSIO/makefile (modified)
	* trunk/external/atnf/pks/makefile (modified)
	* trunk/external/atnf/pks/pks_maths.cc (modified)

	update from livedata CVS


Wed, 19 Nov 2008 03:15:36 GMT MarkCalabretta [1450]
	* trunk/src/STFiller.cpp (modified)

	Adapted to new API, PKSreader::read(const PKSrecord &).


Wed, 19 Nov 2008 03:14:26 GMT MarkCalabretta [1449]
	* trunk/src/STWriter.cpp (modified)

	Adapted to new API, PKSwriter::write(const PKSrecord &).


Tue, 28 Oct 2008 10:09:24 GMT Malte Marquarding [1444]
	* trunk/src/STFITSImageWriter.cpp (modified)
	* trunk/src/STFITSImageWriter.h (modified)

	Ticket #110: I have added a fix for the FITS header now, This ...


Mon, 01 Sep 2008 01:54:04 GMT Malte Marquarding [1443]
	* trunk/SConstruct (modified)
	* trunk/python/scantable.py (modified)
	* trunk/src/STFITSImageWriter.cpp (added)
	* trunk/src/STFITSImageWriter.h (added)
	* trunk/src/STWriter.cpp (modified)

	Fix ticket #127; still have to add class header hack


Mon, 01 Sep 2008 01:30:15 GMT Malte Marquarding [1442]
	* trunk/apps/SConscript (modified)

	replace deprecated env.Copy


Mon, 01 Sep 2008 01:27:14 GMT Malte Marquarding [1441]
	* trunk/src/Scantable.h (modified)

	tidying


Thu, 28 Aug 2008 04:48:40 GMT Max Voronkov [1440]
	* trunk/src/python_Scantable.cpp (modified)

	added forgotten default unflag option


Thu, 28 Aug 2008 04:00:03 GMT Malte Marquarding [1439]
	* trunk/src/STHeader.cpp (modified)
	* trunk/src/STHeader.h (modified)
	* trunk/src/STMath.cpp (modified)

	added Header diff function. Don't use obstype for conformance test


Thu, 28 Aug 2008 03:58:39 GMT Malte Marquarding [1438]
	* trunk/src/STFiller.cpp (modified)

	allow ALMA specific build


Thu, 28 Aug 2008 03:57:50 GMT Malte Marquarding [1437]
	* trunk/scons/utils.py (modified)

	handle fortran in scons >=0.98


Thu, 28 Aug 2008 03:57:13 GMT Malte Marquarding [1436]
	* trunk/INSTALL (modified)

	move to use ReST tro be able to use the file in wiki/html


Thu, 28 Aug 2008 03:56:32 GMT Malte Marquarding [1435]
	* trunk/python/scantable.py (modified)

	optionally suppress history


Thu, 28 Aug 2008 03:55:49 GMT Malte Marquarding [1434]
	* trunk/bin/asap (modified)
	* trunk/python/__init__.py (modified)

	work with ipython >= 0.8


Thu, 28 Aug 2008 03:54:58 GMT Malte Marquarding [1433]
	* trunk/SConstruct (modified)

	allow ALMA specific build


Thu, 28 Aug 2008 03:54:20 GMT Malte Marquarding [1432]
	* trunk/test/parkes-pol.py (modified)

	fix plotting for various pols


Thu, 28 Aug 2008 03:53:43 GMT Malte Marquarding [1431]
	* trunk/scons/quietinstall.py (modified)

	work with scons >= 0.98


Fri, 11 Jul 2008 01:55:28 GMT Malte Marquarding [1430]
	* trunk/src/Scantable.cpp (modified)
	* trunk/src/Scantable.h (modified)
	* trunk/src/ScantableWrapper.h (modified)

	merged in unflag option from alma branch


Fri, 11 Jul 2008 00:34:47 GMT Malte Marquarding [1429]
	* trunk/src/SConscript (modified)

	Copy -> Clone as it is now deprecated


Fri, 04 Jul 2008 03:24:43 GMT Malte Marquarding [1428]
	* trunk/src/STSelector.cpp (modified)

	Use TaQL style python in queries


Fri, 04 Jul 2008 03:23:49 GMT Malte Marquarding [1427]
	* trunk/external/atnf/PKSIO/MBFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/MBFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSMBrecord.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMBrecord.h (modified)
	* trunk/external/atnf/PKSIO/PKSMS2reader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMS2reader.h (modified)
	* trunk/external/atnf/PKSIO/PKSreader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSreader.h (modified)
	* trunk/external/atnf/PKSIO/SDFITSreader.cc (modified)
	* trunk/external/atnf/pks/pks_maths.cc (modified)
	* trunk/external/atnf/pks/pks_maths.h (modified)
	* trunk/external/atnf/pks/pksmb_support.cc (modified)
	* trunk/external/atnf/pks/pksmb_support.h (modified)

	sync with livedata/implement/atnf


Fri, 20 Jun 2008 03:06:37 GMT Malte Marquarding [1426]
	* trunk/share/ipy_user_conf.py (added)

	add new style ipython configuration


Fri, 20 Jun 2008 03:02:24 GMT Malte Marquarding [1425]
	* trunk/python/asaplotbase.py (modified)

	Handle api change in matplotlib-0.98


Fri, 20 Jun 2008 02:32:56 GMT Malte Marquarding [1424]
	* trunk/src/STFiller.cpp (modified)

	Fix for ticket #135. Regular expression in source name matching was ...


Thu, 22 May 2008 06:50:36 GMT Malte Marquarding [1423]
	* trunk/python/__init__.py (modified)

	fixed wrong indentation


Thu, 22 May 2008 06:38:44 GMT Malte Marquarding [1422]
	* trunk/python/__init__.py (modified)
	* trunk/python/asaplotgui.py (modified)

	added scantable.history rc parameter to optionally suppress history ...


Thu, 22 May 2008 06:02:03 GMT Malte Marquarding [1421]
	* trunk/test/data/MOPS.rpf (added)

	added MOPS test data


Thu, 22 May 2008 02:51:58 GMT Malte Marquarding [1420]
	* trunk/python/asapfitter.py (modified)

	typo fix


Wed, 21 May 2008 05:35:49 GMT Malte Marquarding [1419]
	* trunk/monitor/cgi-bin/asapconfig.py (modified)
	* trunk/monitor/cgi-bin/asapmon.py (modified)

	some updates to make the asapmonitor work again


Wed, 21 May 2008 05:28:14 GMT Malte Marquarding [1418]
	* trunk/monitor/htdocs/asapmon.html.template (modified)

	changed the name oof fields.css


Wed, 21 May 2008 05:26:56 GMT Malte Marquarding [1417]
	* trunk/monitor/htdocs/prototype.js (added)

	added the javascript ajax library


Mon, 19 May 2008 04:19:38 GMT Malte Marquarding [1416]
	* trunk/src/STMath.cpp (modified)

	Provide a more useful warning then 'oh oh'


Thu, 31 Jan 2008 04:32:16 GMT Malte Marquarding [1415]
	* trunk/examples/waterfall.py (added)

	added example for waterfall plots


Thu, 31 Jan 2008 04:18:41 GMT Malte Marquarding [1414]
	* trunk/src/RowAccumulator.cpp (modified)

	only add weight if there is a valid channel


Thu, 31 Jan 2008 04:17:40 GMT Malte Marquarding [1413]
	* trunk/src/STMath.cpp (modified)

	removed debug cout


Thu, 31 Jan 2008 04:17:03 GMT Malte Marquarding [1412]
	* trunk/src/MathUtils.cpp (modified)

	use stl type array iterators as in the new version of casacore


Thu, 31 Jan 2008 04:16:14 GMT Malte Marquarding [1411]
	* trunk/src/Scantable.cpp (modified)
	* trunk/src/Scantable.h (modified)

	added getEpoch member function


Thu, 31 Jan 2008 04:15:02 GMT Malte Marquarding [1410]
	* trunk/src/STFiller.cpp (modified)
	* trunk/src/STWriter.cpp (modified)

	Mark C added brightness unit to PKSreader/writer


Thu, 31 Jan 2008 04:08:38 GMT Malte Marquarding [1409]
	* trunk/python/asapfitter.py (modified)

	use english spelling of centre not center


Thu, 31 Jan 2008 04:07:57 GMT Malte Marquarding [1408]
	* trunk/python/__init__.py (modified)

	use pylab as a reference


Thu, 31 Jan 2008 04:06:37 GMT Malte Marquarding [1407]
	* trunk/apps (added)
	* trunk/apps/SConscript (added)
	* trunk/apps/test.cpp (added)

	added apps directory for c++ binaries e.g. test/debug programs


Thu, 31 Jan 2008 04:03:34 GMT Malte Marquarding [1406]
	* trunk/SConstruct (modified)

	work with the latest version of casacore; made release mode default. ...


Thu, 31 Jan 2008 04:02:38 GMT Malte Marquarding [1405]
	* trunk/web/index.html (modified)

	added warning about large tabke linux bug


Thu, 31 Jan 2008 04:01:47 GMT Malte Marquarding [1404]
	* trunk/INSTALL (modified)

	minor corrections


Thu, 31 Jan 2008 04:01:00 GMT Malte Marquarding [1403]
	* trunk/monitor/cgi-bin/asapconfig.py (modified)
	* trunk/monitor/cgi-bin/obsconfig.py (modified)

	removed some hardcoded locations


Thu, 31 Jan 2008 03:09:52 GMT Malte Marquarding [1402]
	* trunk/python/scantable.py (modified)

	implemented iterator to iterate through rows


Fri, 16 Nov 2007 02:36:15 GMT Malte Marquarding [1399]
	* trunk/external/atnf/PKSIO/FITSreader.h (modified)
	* trunk/external/atnf/PKSIO/MBFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/MBFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSMS2reader.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMS2reader.h (modified)
	* trunk/external/atnf/PKSIO/PKSMS2writer.cc (modified)
	* trunk/external/atnf/PKSIO/PKSMS2writer.h (modified)
	* trunk/external/atnf/PKSIO/PKSSDwriter.cc (modified)
	* trunk/external/atnf/PKSIO/PKSSDwriter.h (modified)
	* trunk/external/atnf/PKSIO/PKSreader.h (modified)
	* trunk/external/atnf/PKSIO/PKSwriter.h (modified)
	* trunk/external/atnf/PKSIO/SDFITSreader.cc (modified)
	* trunk/external/atnf/PKSIO/SDFITSreader.h (modified)
	* trunk/external/atnf/PKSIO/SDFITSwriter.cc (modified)
	* trunk/external/atnf/PKSIO/SDFITSwriter.h (modified)

	Mark C added brightness unit to getHeader()


Wed, 24 Oct 2007 05:57:31 GMT Malte Marquarding [1398]
	* trunk/src/RowAccumulator.cpp (modified)
	* trunk/src/RowAccumulator.h (modified)

	made n_ unsigned integer (from float) to maybe speed things up a bit


Thu, 20 Sep 2007 03:49:45 GMT Malte Marquarding [1397]
	* trunk/web/index.html (modified)

	changed sourcecode->svn


Thu, 16 Aug 2007 00:22:32 GMT Malte Marquarding [1396]
	* trunk/SConstruct (modified)

	Added -Wall flag to debug target


Thu, 16 Aug 2007 00:22:00 GMT Malte Marquarding [1395]
	* trunk/python/scantable.py (modified)

	some minor documentation fixes


Thu, 16 Aug 2007 00:21:27 GMT Malte Marquarding [1394]
	* trunk/doc/userguide.tex (modified)

	some minor fixes for typos and outdated info


Mon, 30 Jul 2007 23:30:35 GMT Malte Marquarding [1392]
	* trunk/python/scantable.py (modified)

	didn't setup times in case of asdatetime


Mon, 30 Jul 2007 01:59:36 GMT Malte Marquarding [1391]
	* trunk/python/asapfitter.py (modified)
	* trunk/python/asapmath.py (modified)
	* trunk/python/asapplotter.py (modified)
	* trunk/python/scantable.py (modified)
	* trunk/src/STAttr.cpp (modified)
	* trunk/src/STDefs.h (modified)
	* trunk/src/STFiller.cpp (modified)
	* trunk/src/STFiller.h (modified)
	* trunk/src/STFitter.cpp (modified)
	* trunk/src/STFitter.h (modified)
	* trunk/src/STMath.cpp (modified)
	* trunk/src/STMath.h (modified)
	* trunk/src/STMathWrapper.h (modified)
	* trunk/src/STSelector.cpp (modified)
	* trunk/src/STTcal.cpp (modified)
	* trunk/src/STWriter.cpp (modified)
	* trunk/src/STWriter.h (modified)
	* trunk/src/Scantable.cpp (modified)
	* trunk/src/Scantable.h (modified)
	* trunk/src/ScantableWrapper.h (modified)
	* trunk/src/python_Fitter.cpp (modified)
	* trunk/src/python_STMath.cpp (modified)
	* trunk/src/python_Scantable.cpp (modified)

	merge from alma branch to get alma/GBT support. Commented out ...


Fri, 27 Jul 2007 01:29:54 GMT Malte Marquarding [1390]
	* trunk/src/STWriter.cpp (modified)

	fix for scanning data, where direction can change per cycle not only ...


Fri, 13 Jul 2007 02:09:58 GMT mar637 [1385]
	* trunk/src/Scantable.h (modified)
	* trunk/src/ScantableWrapper.h (modified)

	a couple more explicit keywords for constructors deafaulting to one ...


Fri, 13 Jul 2007 02:08:18 GMT mar637 [1384]
	* trunk/src/STMath.cpp (modified)

	use CountedPtr to prevent potential leaks